>From Ali Alsuliman <[email protected]>: Attention is currently required from: Michael Blow.
Ali Alsuliman has posted comments on this change by Michael Blow. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20598?usp=email ) Change subject: WIP: delayed vsizeframe shrink ...................................................................... Patch Set 4: (2 comments) File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/DelayedShrinkVSizeFrame.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20598/comment/2db09c2e_d9bb9398?usp=email : PS4, Line 33: (10); Is it going to be hard if we make this configurable? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20598/comment/fe21dee5_7ff715bf?usp=email : PS4, Line 46: LOGGER.info I think these logs could be noisy. We could make them TRACE and enable them when we are debugging with customers. What we probably want to do is keep track of them and report them at possible: * close() of certain operators that we know it will be helpful (DcpRouteOp). * include them in the stats for each operator. We can discuss how to do that (pass the stats collector here, or the profiled op getting the stats from here, ... etc. I would say this is a TODO (maybe for now we can do it only for DcpRouteOp if we think it is going to be helpful). -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20598?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I492d341e84675cca57cef937fcbf4851379981cf Gerrit-Change-Number: 20598 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Mon, 12 Jan 2026 16:00:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
