>From Michael Blow <[email protected]>:

Attention is currently required from: Ali Alsuliman.

Michael Blow has posted comments on this change by Michael Blow. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20598?usp=email )

Change subject: WIP: delayed vsizeframe shrink
......................................................................


Patch Set 4:

(2 comments)

File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/DelayedShrinkVSizeFrame.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20598/comment/05d4d9ca_4d8bd58d?usp=email
 :
PS4, Line 33: (10);
> Is it going to be hard if we make this configurable?
I don't think so- that was my goal. It's not clear that this is the "right" 
solution for what we want, but this at least seemed to be a step into the right 
direction.


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20598/comment/6c92d081_d48bdaef?usp=email
 :
PS4, Line 46: LOGGER.info
> I think these logs could be noisy. […]
Agreed- this was more for debugging purposes- we should however have a metric 
for this, that is not chatty.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20598?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I492d341e84675cca57cef937fcbf4851379981cf
Gerrit-Change-Number: 20598
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Blow <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Comment-Date: Wed, 28 Jan 2026 22:43:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ali Alsuliman <[email protected]>

Reply via email to