>From ongdisheng: Attention is currently required from: Ian Maxon.
ongdisheng has posted comments on this change by Ian Maxon. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21007?usp=email ) Change subject: [ASTERIXDB-2877][EXT] Fix multi-byte/emoji character corruption in CSV output ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: LGTM with one minor question regarding the escape character usage. File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21007/comment/ab2c7928_4d135c4d?usp=email : PS1, Line 343: os.write((byte) quoteChar); Hi @[email protected], this uses `quoteChar` for escaping instead of the `escape` parameter. Just wondering if this is intentional to enforce RFC 4180 quote doubling? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21007?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I434142a9b9cd2d1fc941b1e1f350e97403a8a3e1 Gerrit-Change-Number: 21007 Gerrit-PatchSet: 1 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: ongdisheng Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Sun, 15 Mar 2026 10:28:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
