>From Ian Maxon <[email protected]>:

Attention is currently required from: ongdisheng.

Ian Maxon has posted comments on this change by Ian Maxon. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21007?usp=email )

Change subject: [ASTERIXDB-2877][EXT] Fix multi-byte/emoji character corruption 
in CSV output
......................................................................


Patch Set 2:

(1 comment)

File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21007/comment/6461b38f_04182643?usp=email
 :
PS2, Line 322: char quote
> +1 on compile time checking […]
Oh, very nice detective work. That's very convenient and good then; I was down 
a rabbit hole trying to make all this work with a byte[] of any codepoint as 
UTF-8. I'll remove the runtime check as it's redundant.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21007?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I434142a9b9cd2d1fc941b1e1f350e97403a8a3e1
Gerrit-Change-Number: 21007
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: ongdisheng
Gerrit-CC: Hussain Towaileb <[email protected]>
Gerrit-CC: Murtadha Hubail <[email protected]>
Gerrit-Attention: ongdisheng
Gerrit-Comment-Date: Fri, 20 Mar 2026 22:06:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ongdisheng
Comment-In-Reply-To: Ian Maxon <[email protected]>

Reply via email to