>From Ali Alsuliman <[email protected]>: Attention is currently required from: Hussain Towaileb, Preetham Poluparthi, Shahrzad Shirazi.
Ali Alsuliman has posted comments on this change by Shahrzad Shirazi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123?usp=email ) Change subject: Merge branch 'gerrit/phoenix' into 'gerrit/lumina' ...................................................................... Patch Set 8: (7 comments) File asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/disjunctive-predicate/disjunctive-predicate-5.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/b9ef0da5_ca171ae8?usp=email : PS8, Line 21: unnest-map [$$23, $$x] <- index-search("TestSet", 0, "Default", "test", "TestSet", true, false, 1, $$27, 1, $$27, true, true, true) limit 2 This `limit 2` is weird. How come it's pushed down without the condition in the SELECT op below the original LIMIT op? File asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562_ps.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/79729776_04976787?usp=email : PS8, Line 1: distribute result [$$154] The file should be removed and not merged forward. File asterixdb/asterix-app/src/test/resources/optimizerts/results/query_issue3316_v2.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/8747197c_fe1a9968?usp=email : PS8, Line 1: distribute result [$$217] Same comment regarding keeping the content of the file the same as the one in Phoenix (with the only difference is the plan changes and variables numbering) File asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/query_issue3316_v2.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/147ffdd2_46f651d3?usp=email : PS8, Line 1: distribute result [$$217] [cardinality: 1000000.0, doc-size: -1.0, op-cost: 0.0, total-cost: 1000000.0] This file is different from the original one in Phoenix. The original file in Phoenix does not have `[cardinality: 1000000.0, doc-size:.....`. We should merge forward the same exact file with the only modifications to the variables numbering to avoid test failure if any. File asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/tpch/q12_shipping_broadcast_ps_v2.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/1200bae1_8dc58f2c?usp=email : PS8, Line 1: distribute result [$$126] [cardinality: 1000000.0, doc-size: -2.0, op-cost: 0.0, total-cost: 1.1E7] Those files with `_ps` should actually be not merge forwarded from Phoenix to Lumina (reason is because this patch was trying to get rid of them https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441). File asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-selection/btree-index-range-02/btree-index-range-02.04.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/43eca93b_9a3c6ce0?usp=email : PS8, Line 1: distribute result [$$54] [cardinality: 33.87, doc-size: 0.0, op-cost: 0.0, total-cost: 162608.96] The content being merged here is the old index-only plan content. We need to preserve the new index-only plan in master. This comment applies to other files in this merge commit. File asterixdb/asterix-app/src/test/resources/runtimets/sqlpp_queries.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/c9c903a6_9f15f330?usp=email : PS8, Line 6442: <test-case FilePath="index-selection"> Remove 2 spaces before `<test-case FilePath="index-selection">` -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I6b1cece23e630df51a72160ab7b64b8d450cedc6 Gerrit-Change-Number: 21123 Gerrit-PatchSet: 8 Gerrit-Owner: Shahrzad Shirazi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preetham Poluparthi <[email protected]> Gerrit-Attention: Shahrzad Shirazi <[email protected]> Gerrit-Attention: Preetham Poluparthi <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Tue, 14 Apr 2026 18:39:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
