>From Shahrzad Shirazi <[email protected]>:

Attention is currently required from: Ali Alsuliman, Hussain Towaileb, Preetham 
Poluparthi.

Shahrzad Shirazi has posted comments on this change by Shahrzad Shirazi. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123?usp=email )

Change subject: Merge branch 'gerrit/phoenix' into 'gerrit/lumina'
......................................................................


Patch Set 10: Code-Review+1

(7 comments)

File 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/disjunctive-predicate/disjunctive-predicate-5.plan:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/3d609baf_cf750d88?usp=email
 :
PS8, Line 21:                     unnest-map [$$23, $$x] <- 
index-search("TestSet", 0, "Default", "test", "TestSet", true, false, 1, $$27, 
1, $$27, true, true, true) limit 2
> This `limit 2` is weird. […]
Acknowledged


File 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562_ps.plan:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/282d6ba4_d60f9c5d?usp=email
 :
PS8, Line 1: distribute result [$$154]
> The file should be removed and not merged forward.
Done


File 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query_issue3316_v2.plan:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/95769e24_8463acfd?usp=email
 :
PS8, Line 1: distribute result [$$217]
> Same comment regarding keeping the content of the file the same as the one in 
> Phoenix (with the only […]
Done


File 
asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/query_issue3316_v2.plan:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/08d19b21_7e8e0664?usp=email
 :
PS8, Line 1: distribute result [$$217] [cardinality: 1000000.0, doc-size: -1.0, 
op-cost: 0.0, total-cost: 1000000.0]
> This file is different from the original one in Phoenix. […]
Done


File 
asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/tpch/q12_shipping_broadcast_ps_v2.plan:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/d2dce913_ca22a551?usp=email
 :
PS8, Line 1: distribute result [$$126] [cardinality: 1000000.0, doc-size: -2.0, 
op-cost: 0.0, total-cost: 1.1E7]
> Those files with `_ps` should actually be not merge forwarded from Phoenix to 
> Lumina (reason is beca […]
Done


File 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-selection/btree-index-range-02/btree-index-range-02.04.plan:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/d7cbc19f_1c2e584f?usp=email
 :
PS8, Line 1: distribute result [$$54] [cardinality: 33.87, doc-size: 0.0, 
op-cost: 0.0, total-cost: 162608.96]
> The content being merged here is the old index-only plan content. […]
Done


File asterixdb/asterix-app/src/test/resources/runtimets/sqlpp_queries.xml:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123/comment/7c4b4d19_a90b0e7e?usp=email
 :
PS8, Line 6442:       <test-case FilePath="index-selection">
> Remove 2 spaces before `<test-case FilePath="index-selection">`
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21123?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: lumina
Gerrit-Change-Id: I6b1cece23e630df51a72160ab7b64b8d450cedc6
Gerrit-Change-Number: 21123
Gerrit-PatchSet: 10
Gerrit-Owner: Shahrzad Shirazi <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Preetham Poluparthi <[email protected]>
Gerrit-Reviewer: Shahrzad Shirazi <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Preetham Poluparthi <[email protected]>
Gerrit-Attention: Hussain Towaileb <[email protected]>
Gerrit-Comment-Date: Wed, 15 Apr 2026 17:28:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ali Alsuliman <[email protected]>

Reply via email to