Till Westmann has posted comments on this change. Change subject: Fix transaction logs and optimize upserts ......................................................................
Patch Set 7: (34 comments) All comments are on form and not on function as someone with a deeper understanding of the function should comment on that. It would really be helpful, if the commit message would have a more detailed description. https://asterix-gerrit.ics.uci.edu/#/c/1554/7//COMMIT_MSG Commit Message: PS7, Line 7: Fix transaction logs and optimize upserts Add some details on "Fix transaction logs" and "optimize upserts" below the summary? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java: PS7, Line 145: -1 Keep the DatasetId and create a static constant for the DatasetId(-1)? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java: PS7, Line 198: -1 Keep the DatasetId and create a static constant for the DatasetId(-1)? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/AbstractOperationCallback.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/AbstractOperationCallback.java: PS7, Line 29: int Keep the DatasetId? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILockManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILockManager.java: PS7, Line 51: int Keep the DatasetId? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogRecord.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogRecord.java: PS7, Line 52: DS_LEN Keep the DatasetId? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITransactionManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITransactionManager.java: PS7, Line 79: int Keep the DatasetId? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java: PS7, Line 125: int Keep the DatasetId? PS7, Line 168: - Keep the DatasetId and create a static constant for the DatasetId(-1)? PS7, Line 176: - Keep the DatasetId and create a static constant for the DatasetId(-1)? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataIndex.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataIndex.java: PS7, Line 81: int Keep the DatasetId? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataIndex.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataIndex.java: PS7, Line 79: int Keep the DatasetId? PS7, Line 272: int Keep the DatasetId? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/job/listener/JobEventListenerFactory.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/job/listener/JobEventListenerFactory.java: PS7, Line 57: - Keep the DatasetId and create a static constant for the DatasetId(-1)? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/job/listener/MultiTransactionJobletEventListenerFactory.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/job/listener/MultiTransactionJobletEventListenerFactory.java: PS7, Line 61: - Keep the DatasetId and create a static constant for the DatasetId(-1)? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/std/FlushDatasetOperatorDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/std/FlushDatasetOperatorDescriptor.java: PS7, Line 42: int Keep the DatasetId? PS7, Line 83: datasetId Keep the DatasetId? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java: PS7, Line 102: int Keep the DatasetId? PS7, Line 326: int Keep the DatasetId? PS7, Line 388: int Keep the DatasetId? PS7, Line 424: int Keep the DatasetId? PS7, Line 468: int Keep the DatasetId? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionManager.java: PS7, Line 55: int Keep the DatasetId? PS7, Line 106: int Keep the DatasetId? PS7, Line 128: int Keep the DatasetId? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-transactions/src/test/java/org/apache/asterix/transaction/management/service/locking/LockManagerUnitTest.java File asterixdb/asterix-transactions/src/test/java/org/apache/asterix/transaction/management/service/locking/LockManagerUnitTest.java: PS7, Line 332: int Keep the DatasetId? PS7, Line 345: int Keep the DatasetId? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-transactions/src/test/java/org/apache/asterix/transaction/management/service/locking/Request.java File asterixdb/asterix-transactions/src/test/java/org/apache/asterix/transaction/management/service/locking/Request.java: PS7, Line 58: int Keep the DatasetId? PS7, Line 66: int Keep the DatasetId? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IModificationOperationCallback.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IModificationOperationCallback.java: PS7, Line 59: byte Keep the enum? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/NoOpOperationCallback.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/NoOpOperationCallback.java: PS7, Line 64: byte Keep the enum? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/ophelpers/IndexOperation.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/ophelpers/IndexOperation.java: PS7, Line 36: public static final byte INSERT_BYTE = 0x01; : public static final byte DELETE_BYTE = 0x02; : public static final byte UPSERT_BYTE = 0x03; : : public static final byte getLogRecordOpByte(IndexOperation op) { : switch (op) { : case DELETE: : return DELETE_BYTE; : case INSERT: : return INSERT_BYTE; : case UPSERT: : return UPSERT_BYTE; : default: : throw new IllegalArgumentException("Op"); : } : } : } > Will move this to asterixdb since hyracks shouldn't be aware of logs Indeed! Good point! https://asterix-gerrit.ics.uci.edu/#/c/1554/7/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/AbstractModificationOperationCallbackTest.java File hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/AbstractModificationOperationCallbackTest.java: PS7, Line 103: byte Keep the enum? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/common/TestOperationCallback.java File hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/common/TestOperationCallback.java: PS7, Line 70: byte Keep the enum? -- To view, visit https://asterix-gerrit.ics.uci.edu/1554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice5296267033cd7debe76894c864c6411f761d83 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
