abdullah alamoudi has posted comments on this change. Change subject: Fix transaction logs and optimize upserts ......................................................................
Patch Set 7: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java: PS7, Line 691: getNewValue > In addition, to be consistent, for a DELETE record, should be the deleted v I think you're right. Done PS7, Line 697: forceUpsert > This does not seem entirely right to me... recovery operations don't create logs. they are memory only operations and they must never fail. If they fail, system is in an unstable state. PS7, Line 699: > A related question: does each individual undo operation has an entity comm recovery ops don't create any logs. -- To view, visit https://asterix-gerrit.ics.uci.edu/1554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice5296267033cd7debe76894c864c6411f761d83 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
