>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Preetham Poluparthi.
Ali Alsuliman has posted comments on this change by Preetham Poluparthi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20958?usp=email ) Change subject: [ASTERIXDB-3707][EXT] Add file level split while reading parquet files ...................................................................... Patch Set 9: (2 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20958/comment/eb758107_2476b91a?usp=email : PS9, Line 118: private boolean useFileSplits = false; Can we make `useFileSplits` local? It seems like we don't need it to be a member (and therefore not be part of the factory serialization) File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20958/comment/f2979641_f2157611?usp=email : PS9, Line 1025: DatasetDataSource.setExternalCollectionCompilerProperties(this, configuration); Why is this here? `setExternalCollectionCompilerProperties()` is already called in `DatasetDataSource.buildDatasourceScanRuntime()`. With this, `setExternalCollectionCompilerProperties()` will be called twice, one time in `DatasetDataSource.buildDatasourceScanRuntime()`, and a second time when `metadataProvider.getConfiguredAdapterFactory()` is called as part of `DatasetDataSource.buildDatasourceScanRuntime()`. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20958?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I288908499c90320f9fc497675ef3d671163c69f0 Gerrit-Change-Number: 20958 Gerrit-PatchSet: 9 Gerrit-Owner: Preetham Poluparthi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Preetham Poluparthi <[email protected]> Gerrit-Comment-Date: Thu, 30 Apr 2026 00:36:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
