>From Preetham Poluparthi <[email protected]>:

Attention is currently required from: Ali Alsuliman, Murtadha Hubail.

Preetham Poluparthi has posted comments on this change by Preetham Poluparthi. 
( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20958?usp=email )

Change subject: [ASTERIXDB-3707][EXT] Add file level split while reading 
parquet files
......................................................................


Patch Set 11:

(2 comments)

File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20958/comment/146fb35b_72146af3?usp=email
 :
PS9, Line 118:     private boolean useFileSplits = false;
> Can we make `useFileSplits` local? It seems like we don't need it to be a 
> member (and therefore not  […]
Done


File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20958/comment/55dc7571_6ccee81a?usp=email
 :
PS9, Line 1025:             
DatasetDataSource.setExternalCollectionCompilerProperties(this, configuration);
> Why is this here? `setExternalCollectionCompilerProperties()` is already 
> called in `DatasetDataSourc […]
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20958?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: lumina
Gerrit-Change-Id: I288908499c90320f9fc497675ef3d671163c69f0
Gerrit-Change-Number: 20958
Gerrit-PatchSet: 11
Gerrit-Owner: Preetham Poluparthi <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Comment-Date: Thu, 30 Apr 2026 13:05:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ali Alsuliman <[email protected]>

Reply via email to