>From Michael Blow <[email protected]>:

Attention is currently required from: Preetham Poluparthi.

Michael Blow has posted comments on this change by Preetham Poluparthi. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277?usp=email )

Change subject: [ASTERIXDB-3768][CLOUD] restore Content-MD5 for S3-compatible 
endpoints via LegacyMd5Plugin
......................................................................


Patch Set 2:

(1 comment)

File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/be33a532_a5b42e07?usp=email
 :
PS2, Line 217:                 builder.addPlugin(LegacyMd5Plugin.create());
It makes me nervous to always include this, while it works with OCI it could 
break another vendor. Perhaps we should add another S3ChecksumBehavior option, 
e.g. `WHEN_REQUIRED_WITH_CONTENT_MD5` to enable this. We could make this option 
the default for endpoint defined, but at least we would have a way out of it 
for any solution that didn't allow it without a code change.

What is happening on Go side?



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: lumina
Gerrit-Change-Id: I9443c9327a6bedb7e39c2ef1b729962b2237a974
Gerrit-Change-Number: 21277
Gerrit-PatchSet: 2
Gerrit-Owner: Preetham Poluparthi <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-CC: Michael Blow <[email protected]>
Gerrit-Attention: Preetham Poluparthi <[email protected]>
Gerrit-Comment-Date: Fri, 22 May 2026 13:10:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to