>From Michael Blow <[email protected]>: Attention is currently required from: Preetham Poluparthi.
Michael Blow has posted comments on this change by Preetham Poluparthi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277?usp=email ) Change subject: [ASTERIXDB-3768][CLOUD] restore Content-MD5 for S3-compatible endpoints via LegacyMd5Plugin ...................................................................... Patch Set 3: (1 comment) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/ed62d06d_a4b80784?usp=email : PS2, Line 217: builder.addPlugin(LegacyMd5Plugin.create()); > It makes me nervous to always include this, while it works with OCI it could > break another vendor. […] ChatGPT really doesn't like adding a third enum value for this, he instead prefers a separate knob, that we'll need to decide what is the best value for. If we add a flag e.g. `blobStorageS3LegacyMd5Checksum`, we will need to decide on the best default value for both new clusters and on upgrade. I also noticed a related compatibility toggle we might want to include as well, chunkedEncodingEnabled. (e.g. `blobStorageS3DisableChunkedEncoding`). -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I9443c9327a6bedb7e39c2ef1b729962b2237a974 Gerrit-Change-Number: 21277 Gerrit-PatchSet: 3 Gerrit-Owner: Preetham Poluparthi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Preetham Poluparthi <[email protected]> Gerrit-Comment-Date: Sun, 24 May 2026 01:47:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Blow <[email protected]>
