>From Calvin Thomas Dani <[email protected]>: Attention is currently required from: Ian Maxon.
Calvin Thomas Dani has posted comments on this change by Calvin Thomas Dani. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159?usp=email ) Change subject: [ASTERIXDB-3760] Training VTree index ...................................................................... Patch Set 9: (6 comments) File asterixdb/asterix-common/pom.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159/comment/4fd46a2b_8106260a?usp=email : PS5, Line 205: <version>0.3.10-SNAPSHOT</version> > should use the ${project. […] There an error when i use ${project.version}. Will address that i think its a downstream error with how the storage pom is defined. File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SampleOperationsHelper.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159/comment/25f5a2cd_c3e1584b?usp=email : PS5, Line 177: // @Override > why's this not overridden now? Done File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryVectorOperationsHelper.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159/comment/e2bf4cea_bbb07cd8?usp=email : PS5, Line 236: sampleSize = Math.max(sampleSize, 10000); : sampleSize = Math.min(sampleSize, 1000000); > would be nice to have these as config options set at their respective values > as default rather than […] done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159/comment/b4c52fb0_4aca12f3?usp=email : PS5, Line 425: UUID permitUUID = UUID.randomUUID(); : UUID materializedDataUUID = UUID.randomUUID(); > these UUIDs aren't used anymore right? done File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/QuantizationConstantsAggregateDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159/comment/6004f9ca_9d6f0024?usp=email : PS5, Line 131: TEMPORARY > should this still be here? Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159/comment/4a763eea_1fdf72df?usp=email : PS5, Line 292: ystem.err.println > should migrate this to LOGGER::trace or something Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21159?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1264840ffd536d91c0ee11634abfd35a0ad79ecd Gerrit-Change-Number: 21159 Gerrit-PatchSet: 9 Gerrit-Owner: Calvin Thomas Dani <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Mon, 01 Jun 2026 10:48:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]>
