>From Rithwik Koul <[email protected]>: Attention is currently required from: Ali Alsuliman, Ian Maxon, Murtadha Hubail, Murtadha Hubail.
Rithwik Koul has posted comments on this change by Rithwik Koul. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328?usp=email ) Change subject: [ASTERIXDB-3183][COMP] Add query plan cache ...................................................................... Patch Set 58: (4 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponseMetrics.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/26d6db2d_900fe133?usp=email : PS45, Line 122: cachedPlan > isCachedPlan Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/22caf061_dc87c6af?usp=email : PS45, Line 4670: // Interface (IStatementExecutor) entry point: no result metadata and no cached plan. Delegates to the : // cache-aware overload below (used by handleQuery's miss/hit paths). > ? Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/692ca0de_498e9de0?usp=email : PS45, Line 5675: rewriteCompileQuery > I feel like this path should be shared with cache miss Done File hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/api/ICompiler.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/c1411826_93cf70fc?usp=email : PS45, Line 41: the query plan cache : * retains it so a hit can call {@link #createJob} without re-optimizing. > Remove it Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I116e5fa9d16e5c4a5cc6dfbdf8db230221086a9d Gerrit-Change-Number: 21328 Gerrit-PatchSet: 58 Gerrit-Owner: Rithwik Koul <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail Gerrit-CC: Ian Maxon <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Mon, 29 Jun 2026 08:57:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]>
