>From Rithwik Koul <[email protected]>: Attention is currently required from: Ali Alsuliman, Ian Maxon, Murtadha Hubail, Murtadha Hubail.
Rithwik Koul has posted comments on this change by Rithwik Koul. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328?usp=email ) Change subject: [ASTERIXDB-3183][COMP] Add query plan cache ...................................................................... Patch Set 58: (9 comments) Patchset: PS45: > ah ok cool. […] Yes and I've mentioned everything in this doc - https://docs.google.com/document/d/17RmRGkfauYp0039OXw9D_F_k_MV0rRc7G50YHyjic3I/edit?usp=sharing File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/0779fb49_2ff09e03?usp=email : PS36, Line 29: Map > Not sure if we need to implement Map here or just have the map as a variable Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCacheKey.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/03131e02_f920790f?usp=email : PS36, Line 38: QueryCacheKey > As discussed, we need to find all variables that can impact the optimized plan Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/58a87cbf_34fda3ba?usp=email : PS36, Line 5724: PlanToCache > Do we really need this? Acknowledged File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/cc5b5138_c85fb106?usp=email : PS45, Line 2903: protected void clearCache() throws Exception { : HttpUriRequest method = constructDeleteMethod(getEndpoint(Servlets.PLAN_CACHE), Collections.emptyList()); : HttpResponse response = executeHttpRequest(method); : if (response.getStatusLine().getStatusCode() != HttpStatus.SC_OK) { : throw new Exception("HTTP error " + response.getStatusLine().getStatusCode() + ":\n" + response); : } : } > revert Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cache/IQueryCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/7e2d4008_883fc865?usp=email : PS45, Line 22: (raw request text + plan-affecting inputs) t > This shouldn't be in the interface as it's implementation dependent Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/13645aad_a0168f79?usp=email : PS45, Line 38: void clear(); > Remove one of these Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/759a7683_1c5e41f4?usp=email : PS45, Line 45: int size(); > remove if not used Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cache/QueryCacheKey.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328/comment/4f69f531_29bd0b43?usp=email : PS45, Line 48: String discriminator > we should not implement this like this. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21328?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I116e5fa9d16e5c4a5cc6dfbdf8db230221086a9d Gerrit-Change-Number: 21328 Gerrit-PatchSet: 58 Gerrit-Owner: Rithwik Koul <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail Gerrit-CC: Ian Maxon <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Mon, 29 Jun 2026 08:58:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Rithwik Koul <[email protected]>
