Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-1990][ASTERIXDB-1991][ASTERIXDB-2025][STO] Fix Merge ......................................................................
Patch Set 11: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1930/11//COMMIT_MSG Commit Message: PS11, Line 7: [ASTERIXDB-1990][ASTERIXDB-1991][ASTERIXDB-2025] If there's a single cause for these 3 issues, maybe we can indicate the relationship on the issues (one is a duplicate of another or one subsumes another) and only have one issue listed here? https://asterix-gerrit.ics.uci.edu/#/c/1930/11/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java: PS11, Line 72: completeOperation This is confusing. If the methods - beforeOperation, - afterOperation, and - completeOperation are called in that order, it seems that the active IO operations are increased by 1 for FLUSH, MERGE, and REPLICATE and decreased by 2 for FLUSH and REPLICATE and decreased by 1 for MERGE. It seems that an increase by 1 is missing for FLUSH and REPLICATE, is that correct? https://asterix-gerrit.ics.uci.edu/#/c/1930/11/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java: PS11, Line 92: WARNING Why is this a warning? Would INFO or DEBUG be sufficient? PS11, Line 93: in th s/in th /on/ PS11, Line 93: the s/the // https://asterix-gerrit.ics.uci.edu/#/c/1930/11/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS11, Line 354: and Should this be an "or"? -- To view, visit https://asterix-gerrit.ics.uci.edu/1930 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I843de8b26c181205e43f4eabe22a7c43f3ebfcbc Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
