abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-1990][ASTERIXDB-1991][ASTERIXDB-2025][STO] Fix Merge ......................................................................
Patch Set 11: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/1930/11//COMMIT_MSG Commit Message: PS11, Line 7: [ASTERIXDB-1990][ASTERIXDB-1991][ASTERIXDB-2025] > If there's a single cause for these 3 issues, maybe we can indicate the rel Done https://asterix-gerrit.ics.uci.edu/#/c/1930/11/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java: PS11, Line 72: completeOperation > This is confusing. If the methods Hmmm, For flush and replicate, completeOperation is called in afterOperation since they don't have a file deletion step. For merge, the completeOperation is called after the deletion of inactive disk components. https://asterix-gerrit.ics.uci.edu/#/c/1930/11/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java: PS11, Line 92: WARNING > Why is this a warning? Would INFO or DEBUG be sufficient? Done PS11, Line 93: in th > s/in th /on/ Done PS11, Line 93: the > s/the // Done https://asterix-gerrit.ics.uci.edu/#/c/1930/11/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS11, Line 354: and > Should this be an "or"? Done PS11, Line 568: opTracker > Add a comment, why we call the opTracker here? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1930 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I843de8b26c181205e43f4eabe22a7c43f3ebfcbc Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
