Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2169][STO][TX] Unblock modifications during full scan ......................................................................
Patch Set 8: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2166/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java: PS6, Line 97: // We should do this reg > We shouldn't. Hmm...I was suggesting something different here. So we need to check and switch memory component only if the current query holds some memory components. Maybe we can add some variable to track this. If the current query does not hold memory components (e.g., because they're already released), then no need to enter this checks any more... -- To view, visit https://asterix-gerrit.ics.uci.edu/2166 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37ba52f6324ed1c5a78465c3a8cbcd351f1ed5bc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
