abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2169][STO][TX] Unblock modifications during full scan ......................................................................
Patch Set 8: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2166/8/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/SearchCursorComponentSwitchTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/SearchCursorComponentSwitchTest.java: PS8, Line 71: public class SearchCursorComponentSwitchTest { : private static final IAType[] KEY_TYPES = { BuiltinType.AINT32 }; : private static final ARecordType RECORD_TYPE = new ARecordType("TestRecordType", new String[] { "key", "value" }, : new IAType[] { BuiltinType.AINT32, BuiltinType.AINT64 }, false); : private static final GenerationFunction[] RECORD_GEN_FUNCTION = : { GenerationFunction.DETERMINISTIC, GenerationFunction.DETERMINISTIC }; : private static final boolean[] UNIQUE_RECORD_FIELDS = { true, false }; : private static final ARecordType META_TYPE = null; : private static final GenerationFunction[] META_GEN_FUNCTION = null; : private static final boolean[] UNIQUE_META_FIELDS = null; : private static final int[] KEY_INDEXES = { 0 }; : private static final int[] KEY_INDICATORS = { Index.RECORD_INDICATOR }; : private static final List<Integer> KEY_INDICATORS_LIST = Arrays.asList(new Integer[] { Index.RECORD_INDICATOR }); : private static final int TOTAL_NUM_OF_RECORDS = 2000; : private static final int RECORDS_PER_COMPONENT = 1000; : private static final int DATASET_ID = 101; : private static final String DATAVERSE_NAME = "TestDV"; : private static final String DATASET_NAME = "TestDS"; : private static final String DATA_TYPE_NAME = "DUMMY"; : private static final String NODE_GROUP_NAME = "DEFAULT"; : private static final StorageComponentProvider storageManager = new StorageComponentProvider(); : private static TestNodeController nc; : private static TestLsmBtree lsmBtree; : private static NCAppRuntimeContext ncAppCtx; : private static IDatasetLifecycleManager dsLifecycleMgr; : private static Dataset dataset; : private static IHyracksTaskContext ctx; : private static IIndexDataflowHelper indexDataflowHelper; : private static ITransactionContext txnCtx; : private static LSMInsertDeleteOperatorNodePushable insertOp; > Some thought on this class...As we've discussed today, is it possible that 100% agree https://asterix-gerrit.ics.uci.edu/#/c/2166/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java: PS6, Line 97: // We should do this reg > Hmm...I was suggesting something different here. So we need to check and sw That would work but I am not sure about the value it will add since in that case, we will simply enter here, check that switchPossible = false; and will check that includeMutableComponent = false. These are few ns per (n=100) calls -- To view, visit https://asterix-gerrit.ics.uci.edu/2166 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37ba52f6324ed1c5a78465c3a8cbcd351f1ed5bc Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
