Ian Maxon has posted comments on this change. Change subject: Fix for ASTERIXDB-1247 ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/575/2/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: Line 1204: return false; > return true. D'oh! https://asterix-gerrit.ics.uci.edu/#/c/575/2/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexExamplesTest.java File hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexExamplesTest.java: Line 745: treeIndex.getBufferCache().finishQueue(); > calling finishQueue explicitly here doesn't sound right unless this is a sc I don't think it is something normal. Basically, from what I can tell, the reason this was happening was the index would be destroyed before the queue could be written out. Normally in end() we call finishQueue(). -- To view, visit https://asterix-gerrit.ics.uci.edu/575 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia580242b3f7753fc2f793f879332de3270ee3fee Gerrit-PatchSet: 2 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
