Murtadha Hubail has posted comments on this change. Change subject: Fix for ASTERIXDB-1247 ......................................................................
Patch Set 4: (3 comments) Please see my comments. Also, checkout the files that are not modified from master to avoid getting git blame :) https://asterix-gerrit.ics.uci.edu/#/c/575/4/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTree.java File hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTree.java: Line 913: } clear the list after putting it in the queue. https://asterix-gerrit.ics.uci.edu/#/c/575/4/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java: Line 35: BufferedFileHandle fInfo; Let's replace this by: (just make the write method in buffer cache public and let the exception be propagated) CachedPage cPage = (CachedPage) page; try { bufferCache.write(cPage); } finally { bufferCache.returnPage(cPage); if (DEBUG) { System.out.println("[FIFO] Return page: " + cPage.cpid + "," + cPage.dpid); } } Line 63: public void sync(int fileId, BufferCache bufferCache) throws HyracksDataException { There is no caller for this method. Please remove it, and if there is a need for it, just replace it by bufferCache.force -- To view, visit https://asterix-gerrit.ics.uci.edu/575 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia580242b3f7753fc2f793f879332de3270ee3fee Gerrit-PatchSet: 4 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
