Till Westmann has posted comments on this change. Change subject: Enabled Datasets to use Datatypes from foreign Dataverses ......................................................................
Patch Set 11: Code-Review+1 (4 comments) Looks generally good to me. I've got one high-level question: What are the use-visible changes here? I saw a) it is possible to provide qualified type names for datasets and b) the metadata queries additionally return the DatatypeDataverseName for a dataset. Is there something else? Could you maybe add the description of the user-visible changes to the commit message? (Also, reading the code, it seemed to me that some things would be easier to read if we had the concept of a "qualified name" - both in Java and in the metadata entries. But this is not a request to add that in this change - we'd need a bigger discussion before we did that :) ) https://asterix-gerrit.ics.uci.edu/#/c/558/11/asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java File asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java: Line 253: * WS Line 290: * WS https://asterix-gerrit.ics.uci.edu/#/c/558/11/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java File asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java: Line 84: public String getPrettyTypeName() { getQualifiedName? https://asterix-gerrit.ics.uci.edu/#/c/558/11/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java: Line 762: public String getDatatypeNameUsingThisAnonymousDatatype(JobId jobId, String dataverseName, String datatypeName) Where is this method needed/used? -- To view, visit https://asterix-gerrit.ics.uci.edu/558 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
