Steven Jacobs has posted comments on this change. Change subject: Enabled Datasets to use Datatypes from foreign Dataverses ......................................................................
Patch Set 11: (4 comments) @Abdullah: The tests 16-21 corresponded in order to tests dataset, datatype, dataverse, index, node, and node group. I moved 22 and 23 to be 16 and 17, which makes the code review look bonkers @Till: Those two are all of the user-side changes. I will add them to the commit message. I think a QualifiedName type is a VERY good idea I think I've addressed the lingering issues. I'm uploading a new patchset now https://asterix-gerrit.ics.uci.edu/#/c/558/11/asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java File asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java: Line 253: * > WS Done Line 290: * > WS Done https://asterix-gerrit.ics.uci.edu/#/c/558/11/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java File asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java: Line 84: public String getPrettyTypeName() { > getQualifiedName? Done https://asterix-gerrit.ics.uci.edu/#/c/558/11/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java: Line 762: public String getDatatypeNameUsingThisAnonymousDatatype(JobId jobId, String dataverseName, String datatypeName) > Where is this method needed/used? This was being used in Patchset 1, but is no longer needed. Good Catch! I'll delete it. -- To view, visit https://asterix-gerrit.ics.uci.edu/558 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
