Ildar Absalyamov has posted comments on this change. Change subject: ASTERIXDB-1302 ASTERIXDB-1301 Fix Socket Feed Connection ......................................................................
Patch Set 5: Code-Review+1 (1 comment) I don't have much to add after Till's comments https://asterix-gerrit.ics.uci.edu/#/c/660/5/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java: Line 36: private boolean closed; It's better to explicitly initialize it to false (although it's default value anyways) clarify the logic -- To view, visit https://asterix-gerrit.ics.uci.edu/660 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f6e982440d3577343f2479c3779653a9c3db614 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
