Ildar Absalyamov has posted comments on this change. Change subject: ASTERIXDB-1302 ASTERIXDB-1301 Fix Socket Feed Connection ......................................................................
Patch Set 6: Code-Review+1 (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/660/6/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java File asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java: Line 1228: //#. prepare jobs which will drop corresponding datasets with indexes. Duplicate comment https://asterix-gerrit.ics.uci.edu/#/c/660/6/asterix-app/src/test/resources/runtimets/queries/feeds/drop-dataverse-with-disconnected-feed/drop-dataverse-with-disconnected-feed.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/feeds/drop-dataverse-with-disconnected-feed/drop-dataverse-with-disconnected-feed.1.ddl.aql: Line 20: * Description : Drop a dataverse with disconnected feed WS https://asterix-gerrit.ics.uci.edu/#/c/660/6/asterix-common/src/test/java/org/apache/asterix/test/client/FileFeedSocketAdapterClient.java File asterix-common/src/test/java/org/apache/asterix/test/client/FileFeedSocketAdapterClient.java: Line 76: System.err.println("send " + recordCount); That potentially might generate a lot of noise in the output. Instead could that go through standard Logger, so that one can disable unnecessary log entries? -- To view, visit https://asterix-gerrit.ics.uci.edu/660 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f6e982440d3577343f2479c3779653a9c3db614 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
