Murtadha Hubail has posted comments on this change. Change subject: ASTERIXDB-1340: fix node group nodes order ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/708/1/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java File asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java: Line 775: Collections.copy(nodeNamesClone, nodeNames); > nodeNamesClone = new ArrayList<String>(nodeNames); Done https://asterix-gerrit.ics.uci.edu/#/c/708/1/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java File asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java: Line 140: return nodeNames; > It looks we don't create a new AsterixPropertiesAccessor for every query. The nodes list is not accessed from here, it is being queried every time in SplitsAndConstraintsUtil#splitsForDataset but it is initialized the first time from this list. However, this has nothing to do with the distinct query. If you execute the distinct query alone, it is going to work. Moreover, if you just switch the order of the datasets in the failing query to be "for $t in tmp() for $o in dataset('Orders')" it is going to work without changes. Some query plans make the task execute based on the sorted order of cluster partitions (those are the ones that fail), and the others make it execute on the order the file splits are provided (those are the ones that work). With this fix, the order in both cases will be same. -- To view, visit https://asterix-gerrit.ics.uci.edu/708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e93aedb6cdc57d98f83991ab910476b82bacb15 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
