Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1340: fix node group nodes order
......................................................................


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/708/1/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java
File 
asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java:

Line 140:         return nodeNames;
> The nodes list is not accessed from here, it is being queried every time in
>> "Some query ..., and the others"?

Which code does the distinction of the two cases?  
It seems the distinction is not in 
SplitsAndConstraintsUtil.splitsForDataset(...).


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/708
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e93aedb6cdc57d98f83991ab910476b82bacb15
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-HasComments: Yes

Reply via email to