abdullah alamoudi has posted comments on this change. Change subject: Support Change Feeds and Ingestion of Records with MetaData ......................................................................
Patch Set 12: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/621/12/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java File asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java: Line 439: project.getInputs().set(0, new MutableObject<ILogicalOperator>(metaAndKeysAssign)); > create vars and expressions first, then pass them to constructor. Done Line 461: funcCall.substituteVar(resVar, unnestVar); > Don't use field access here. if needed, use it in the transformer. Done https://asterix-gerrit.ics.uci.edu/#/c/621/12/asterix-algebra/src/main/java/org/apache/asterix/translator/util/PlanTranslationUtil.java File asterix-algebra/src/main/java/org/apache/asterix/translator/util/PlanTranslationUtil.java: Line 89: > remove this Done https://asterix-gerrit.ics.uci.edu/#/c/621/12/asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataFlowController.java File asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataFlowController.java: Line 25: > remove writer from start() postponed for another change. https://asterix-gerrit.ics.uci.edu/#/c/621/12/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: Line 230: } > put the check back. Done https://asterix-gerrit.ics.uci.edu/#/c/621/12/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/FeedDataSource.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/FeedDataSource.java: Line 42: private final int computeCardinality; > check whether variables are needed here!! Done -- To view, visit https://asterix-gerrit.ics.uci.edu/621 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If136a03d424970132dfb09f0dda56e160d4c0078 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
