abdullah alamoudi has posted comments on this change. Change subject: Support Change Feeds and Ingestion of Records with MetaData ......................................................................
Patch Set 14: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/621/14/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java: Line 265: exprRef.setValue(new VariableReferenceExpression(keyVars.get(i))); > This seems not working when you have composite keys... Yingyi, This will still work with composite key. each field will have its own expression. I can add a test case later! https://asterix-gerrit.ics.uci.edu/#/c/621/14/asterix-algebra/src/main/java/org/apache/asterix/translator/util/PlanTranslationUtil.java File asterix-algebra/src/main/java/org/apache/asterix/translator/util/PlanTranslationUtil.java: Line 45: @SuppressWarnings("unchecked") > You no longer need this class? This is still needed for creating field access when the key is in the record part not the meta. Also, I am using the meta key part from two different classes. https://asterix-gerrit.ics.uci.edu/#/c/621/14/asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataFlowController.java File asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataFlowController.java: Line 26: public void start(IFrameWriter writer) throws HyracksDataException; > remove IFrameWriter? Yup. I have added a todo. will do it in a subsequent change :) https://asterix-gerrit.ics.uci.edu/#/c/621/14/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/FeedDataSource.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/FeedDataSource.java: Line 45: private final LogicalVariable metaVar; > remove metaVar and pkVars? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/621 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If136a03d424970132dfb09f0dda56e160d4c0078 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
