Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1378 Fix NPE on Feed Connect After Restart ......................................................................
Patch Set 1: (5 comments) Generally looks good. Added a few comments and it would be good to add a test. https://asterix-gerrit.ics.uci.edu/#/c/766/1/asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java File asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java: Line 237: ITypeTraits[] typeTraits = DatasetUtils.computeTupleTypeTraits(dataset, itemType, metaItemType); Can't we move more of the computation into the DatasetUtils? Maybe add a method that gets the metaItemType for a dataset? https://asterix-gerrit.ics.uci.edu/#/c/766/1/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java File asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java: Line 98: int i = 0; This is unused. https://asterix-gerrit.ics.uci.edu/#/c/766/1/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java: Line 89: LOGGER.warn("Feed has been interrupted. Closing the feed"); InterruptedException only happens if somebody interrupts the thread. Why do we ignore it while re-throwing all other exceptions? https://asterix-gerrit.ics.uci.edu/#/c/766/1/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtils.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtils.java: Line 154: throws AlgebricksException { I'm confused about this change. If I reformat the file with the eclipse formatter in IDEA using our code profile, I get the inverse indentation. Do you know if this behavior is part of the profile? https://asterix-gerrit.ics.uci.edu/#/c/766/1/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java: Line 197: accessor.prettyPrint(); Where does this print to? Should this be removed? -- To view, visit https://asterix-gerrit.ics.uci.edu/766 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8f8696d252868a8cce0afdbaeda0dd046f99186 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
