Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1378 Fix NPE on Feed Connect After Restart
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Just one minor question.

https://asterix-gerrit.ics.uci.edu/#/c/766/2/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
File 
asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java:

Line 89:             //TODO: Find out what could cause an interrupted exception 
beside termination of a job/feed
Why the handling of InterruptedException is different from other exceptions in 
the next catch block?  And why it is swallowed?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/766
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8f8696d252868a8cce0afdbaeda0dd046f99186
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to