Young-Seok Kim has posted comments on this change. Change subject: Deadlock-free locking protocol is enabled ......................................................................
Patch Set 3: (12 comments) I addressed your comments. I will request a code review request again when the build succeeds. https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/UpsertCommitRuntime.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/UpsertCommitRuntime.java: Line 52: } > Did you use the asterixdb codestyle? The code formatting triggered by eclipse's "change method signature" doesn't apply the style even if I set up Eclipse code formatting rules. If I manually apply the format in Eclipse, the style seems to get applied. https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILockManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILockManager.java: Line 45: * @param JobThreadId > remove this annotation Done Line 60: * @param JobThreadId > remove this annotation Done Line 67: * @param JobThreadId > remove this annotation Done Line 80: * @param JobThreadId > remove this annotation Done Line 91: * @param JobThreadId > remove this annotation Done Line 102: * @param JobThreadId > remove this annotation Done https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataNode.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataNode.java: Line 151: public List<Dataset> getDataverseDatasets(JobId jobId, String dataverseName) > code format I applied the code style downloaded from here and setup the Eclipse's code formatting rule during saving changes. But, changes shown here are the applied formatting from the style. I'm also using quite up-to-date eclipse version (Version: Mars.2 Release (4.5.2)) https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java: Line 112: appender = new FrameTupleAppender(writeBuffer); > does this conflict with line 129? removed this line. https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/AbstractIndexModificationOperationCallback.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/AbstractIndexModificationOperationCallback.java: Line 65: logRecord.setLogType(LogType.UPDATE); > Why not do that in the constructor as before? It looks that the parameter Done https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java: Line 51: public static final long NILL = -1l; > -1l->-1L Done https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionSubsystem.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionSubsystem.java: Line 141: private int reportIntervalInSeconds; > Can you add a sub-bullet in the commit message to describe the addition of Done -- To view, visit https://asterix-gerrit.ics.uci.edu/825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie58ae2f519baa53599e99b51bd61ea5f8366dafd Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Young-Seok Kim <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
