Yingyi Bu has posted comments on this change. Change subject: Deadlock-free locking protocol is enabled ......................................................................
Patch Set 4: Code-Review+1 (2 comments) A few minor comments inlined. https://asterix-gerrit.ics.uci.edu/#/c/825/4/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/LockThenSearchOperationCallback.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/LockThenSearchOperationCallback.java: Line 37: public class LockThenSearchOperationCallback extends AbstractOperationCallback implements ISearchOperationCallback { 1. Why does this class implement ISearchOperationCallback instead of IModificationCallBack, since it acquires x lock instead of s lock? 2. The name of the class seems confusing to me. It sounds like a read-operation-call-back but is actually a modification-call-back. Since those are kind of orthogonal to your change, please file JIRA issues if you don't want to address them in this change. https://asterix-gerrit.ics.uci.edu/#/c/825/4/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ISearchOperationCallbackFactory.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ISearchOperationCallbackFactory.java: Line 28: public ISearchOperationCallback createSearchOperationCallback(long resourceId, IHyracksTaskContext ctx, IOperatorNodePushable operatorNodePushable) The last argument could potentially be removed if you address the LockAndThenSearchCallBack issues. -- To view, visit https://asterix-gerrit.ics.uci.edu/825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie58ae2f519baa53599e99b51bd61ea5f8366dafd Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Young-Seok Kim <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
