Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/141#issuecomment-204014583
I think this can and should be much simpler. I'm not sure where the
reluctance to call `config:get` in `couch_file:delete` comes from but I don't
find it objectionable and it will radically simplify this change.
I note, as it's not noted anywhere so far, that the intention of the patch
is to allow the administrator to decide if compacted files are immediately
deleted or just renamed to the `.delete` directory (for removal by an external
process). Cloudant does this to avoid performance issues when deleting large
files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
