eiri commented on a change in pull request #496: Couchdb 3287 pluggable storage
engines
URL: https://github.com/apache/couchdb/pull/496#discussion_r117546219
##########
File path: src/couch/src/couch_server.erl
##########
@@ -559,6 +591,110 @@ db_closed(Server, Options) ->
true -> Server
end.
+
+get_configured_engines() ->
+ ConfigEntries = config:get("couchdb_engines"),
+ Engines = lists:flatmap(fun({Extension, ModuleStr}) ->
+ try
+ [{Extension, list_to_atom(ModuleStr)}]
+ catch _T:_R ->
+ []
+ end
+ end, ConfigEntries),
+ case Engines of
+ [] ->
+ [{"couch", couch_bt_engine}];
+ Else ->
+ Else
+ end.
+
+
+get_engine(Server, DbName, Options) ->
+ #server{
+ root_dir = RootDir,
+ engines = Engines
+ } = Server,
+ case couch_util:get_value(engine, Options) of
+ Ext when is_binary(Ext) ->
+ ExtStr = binary_to_list(Ext),
+ case couch_util:get_value(ExtStr, Engines) of
Review comment:
Here `couch_util:get_value/2` returns `undefined` which _is_ an atom, so we
are ending up with engine set as `{undefined, "/path/dbname.cowabunga"}` (or
whatever came in `Options`), responding "ok" to http api and crashing db
updater a moment later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
