lag-linaro commented on a change in pull request #40: Detect Arch Support
URL: https://github.com/apache/couchdb-pkg/pull/40#discussion_r240306053
 
 

 ##########
 File path: Makefile
 ##########
 @@ -154,10 +154,12 @@ build-rpm:
 
 # ######################################
 copy-pkgs:
-       -chmod a+rwx ../rpmbuild/RPMS/x86_64/couchdb-* ../couchdb/couchdb_* 
2>/dev/null
-       -mkdir -p pkgs/couch/$(DIST) && chmod 777 pkgs/couch/$(DIST)
-       -cp ../rpmbuild/RPMS/x86_64/couchdb-* pkgs/couch/$(DIST) 2>/dev/null
-       -cp ../couchdb/couchdb_* pkgs/couch/$(DIST) 2>/dev/null
+       if [ "$(shell arch)" = "x84_64" ]; then                                 
                \
 
 Review comment:
   I was going to do that, but `../rpmbuild/` did not exist at all in my build.
   
   Thinking about it, maybe this is only relevant for YUM builds?
   
   If so, maybe these lines are not correct and `copy-pkgs` should be removed 
from them: ?
   
   ```
   Makefile:debian: find-couch-dist copy-debian update-changelog dpkg copy-pkgs
   Makefile:precise: find-couch-dist copy-debian precise-prep update-changelog 
dpkg copy-pkgs
   Makefile:trusty: find-couch-dist copy-debian trusty-prep update-changelog 
dpkg copy-pkgs
   ...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to