iilyak commented on a change in pull request #3766:
URL: https://github.com/apache/couchdb/pull/3766#discussion_r815834867
##########
File path: src/smoosh/test/smoosh_tests.erl
##########
@@ -83,12 +83,15 @@ should_enqueue(ChannelType, DbName) ->
should_persist_queue(ChannelType, DbName) ->
?_test(begin
+ {ok, ChannelPid} = smoosh_server:get_channel(ChannelType),
ok = grow_db_file(DbName, 300),
ok = wait_enqueue(ChannelType, DbName),
- Q = channel_queue(ChannelType),
+ ok = smoosh_channel:persist(ChannelPid),
Review comment:
This line defeats the purpose of this test. My understanding of the goal
of the test is to make sure all plumbing is correct and we get to the place
where smoosh persists the state. If we call the function from the test directly
we no longer test the plumbing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
