noahshaw11 commented on a change in pull request #3766:
URL: https://github.com/apache/couchdb/pull/3766#discussion_r816193566
##########
File path: src/smoosh/test/smoosh_tests.erl
##########
@@ -83,12 +83,15 @@ should_enqueue(ChannelType, DbName) ->
should_persist_queue(ChannelType, DbName) ->
?_test(begin
+ {ok, ChannelPid} = smoosh_server:get_channel(ChannelType),
ok = grow_db_file(DbName, 300),
ok = wait_enqueue(ChannelType, DbName),
- Q = channel_queue(ChannelType),
+ ok = smoosh_channel:persist(ChannelPid),
Review comment:
It was more intended to test the functionality of
`smoosh_priority_queue:persist/1` and the read-in on restart. Not necessarily
the initial write that occurs on restart. Testing the initial write has proven
to be difficult due to the racing that occurs between the test and
`smoosh_channel`. Any ideas on solutions to prevent a race from occurring?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
