pgj commented on code in PR #4982:
URL: https://github.com/apache/couchdb/pull/4982#discussion_r1485613155


##########
test/elixir/test/password_cache_test.exs:
##########
@@ -128,11 +128,10 @@ defmodule PasswordCacheTest do
     user1 = Map.replace!(user1, "password", "new_password")
     save_doc(db_name, user1)
 
-    # Wait for auth cache to notice password change
-    :timer.sleep(5500)
-
     # Slow rejection for wrong password
-    assert_cache(:expect_slow, "user1", "wrong_password", :expect_login_fail)
+    retry_until(fn ->

Review Comment:
   Is this an unbounded retry, I wonder?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to