rnewson commented on code in PR #4982:
URL: https://github.com/apache/couchdb/pull/4982#discussion_r1486706933
##########
test/elixir/test/password_cache_test.exs:
##########
@@ -128,11 +128,10 @@ defmodule PasswordCacheTest do
user1 = Map.replace!(user1, "password", "new_password")
save_doc(db_name, user1)
- # Wait for auth cache to notice password change
- :timer.sleep(5500)
-
# Slow rejection for wrong password
- assert_cache(:expect_slow, "user1", "wrong_password", :expect_login_fail)
+ retry_until(fn ->
Review Comment:
turns out chttpd_auth_cache.erl follows the changes feed for the users
database in config and does not notice if config changes. In the new test we
make a new empty db and use it for users_db, but couchdb never notices, and is
therefore following the wrong changes feed, and doesn't notice password changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
