nickva commented on code in PR #5309: URL: https://github.com/apache/couchdb/pull/5309#discussion_r1806731912
########## src/dreyfus/src/clouseau_rpc.erl: ########## @@ -24,32 +24,138 @@ -export([set_purge_seq/2, get_purge_seq/1, get_root_dir/0]). -export([connected/0]). +%% string represented as binary +-type string_as_binary(_Value) :: binary(). Review Comment: There is [nonempty_binary/0](https://www.erlang.org/doc/apps/erts/erlang#t:nonempty_binary/0) as well now if that constrains the type better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
