iilyak commented on code in PR #5309: URL: https://github.com/apache/couchdb/pull/5309#discussion_r1806869169
########## src/dreyfus/src/clouseau_rpc.erl: ########## @@ -24,32 +24,138 @@ -export([set_purge_seq/2, get_purge_seq/1, get_root_dir/0]). -export([connected/0]). +%% string represented as binary +-type string_as_binary(_Value) :: binary(). Review Comment: > As for "string" also, wonder they are plain 7-bit "ascii", utf8 encoded binaries, or a mix? Good question. We don't do anything with them. We just converting `list_to_binary` [here](https://github.com/apache/couchdb/blob/main/src/dreyfus/src/dreyfus_httpd.erl#L334). So we would get whatever the jiffy [would return](https://github.com/apache/couchdb-jiffy/blob/50daa80a62a97ffb6dd46ea9cb8ccb4930cbf1ae/c_src/decoder.c#L191). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
