iilyak commented on code in PR #5546:
URL: https://github.com/apache/couchdb/pull/5546#discussion_r2112349865
##########
src/dreyfus/src/clouseau_rpc.erl:
##########
@@ -285,6 +287,14 @@ analyze(Analyzer, Text) ->
version() ->
rpc({main, clouseau()}, version).
+-spec clouseau_major_vsn() -> null | binary() | no_return().
+clouseau_major_vsn() ->
+ case version() of
+ {ok, <<Major, _/binary>>} -> <<Major>>;
+ {ok, null} -> null;
Review Comment:
> > If we run clouseau in dev mode, it will return null.
>
> Please add a comment about it.
Or change return value from `null` to something self explanatory.
```
{ok, null} -> dev_mode;
{ok, null} -> edge;
{ok, null} -> dev;
{ok, null} -> development;
{ok, null} -> experimental;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
