jiahuili430 commented on code in PR #5546:
URL: https://github.com/apache/couchdb/pull/5546#discussion_r2110042234


##########
src/dreyfus/src/clouseau_rpc.erl:
##########
@@ -285,6 +287,14 @@ analyze(Analyzer, Text) ->
 version() ->
     rpc({main, clouseau()}, version).
 
+-spec clouseau_major_vsn() -> null | binary() | no_return().
+clouseau_major_vsn() ->
+    case version() of
+        {ok, <<Major, _/binary>>} -> <<Major>>;
+        {ok, null} -> null;

Review Comment:
   Thanks to Jay for reminding me of this.
   If we run clouseau in dev mode, it will return `null`.
   ```bash
   cd clouseau
   mvn scala:run -Dname=clouseau1 -Dlauncher=with-cookie -Dcookie=<cookie>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to