nickva commented on code in PR #5603:
URL: https://github.com/apache/couchdb/pull/5603#discussion_r2314834827
##########
src/couch/src/couch_db_engine.erl:
##########
@@ -290,6 +295,14 @@
-callback set_props(DbHandle :: db_handle(), Props :: any()) ->
{ok, NewDbHandle :: db_handle()}.
+% This function is only called by couch_db_updater and
+% couch_db_split, as is guaranteed to be a single threaded call. The
Review Comment:
That language is just a copy from the rest of the couch_db_engine comments.
It's full of comments like:
```% This function is called in the context of couch_db_udpater and as such
is guaranteed to be single threaded for the given DbHandle.```
The API there was written with the idea that it might be implemented someone
not familiar with the OTP (like trying to implement an engine in C on top or
RocksDB etc). However, those alternative implementations haven't happened and
with that in mind I agree that `sequentially` sound better in general today.
I'll use that phrasing but also add an aside that the rest of the module that
would be called called `single threaded`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
