nickva commented on code in PR #5603:
URL: https://github.com/apache/couchdb/pull/5603#discussion_r2314840491
##########
src/couch/src/couch_db_int.hrl:
##########
@@ -32,9 +32,7 @@
before_doc_update = nil, % nil | fun(Doc, Db) -> NewDoc
after_doc_read = nil, % nil | fun(Doc, Db) -> NewDoc
- % feature removed in 3.x, but field kept to avoid changing db record size
- % and breaking rolling cluster upgrade
- waiting_delayed_commit_deprecated,
+ time_seq,
Review Comment:
Good idea, I'l describe its history a bit:
```erlang
% In 2.x versions this field was called waiting_delayed_commit.
% In 3.0->3.5 versions it was deprecated and named
waiting_delayed_commit_deprecated.
% In 3.6+ it was repurposed to keep the time_seq structure.
% This repurposing and deprecating is done in order to avoid changing db
% record sizes and breaking cross-cluster online upgrades.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
