davisp commented on issue #5801: URL: https://github.com/apache/couchdb/issues/5801#issuecomment-3604331706
First things first, I absolutely don’t care at all about the switch to stdlib, but I do feel required to refute one point in particular: > * Enhanced safety (by way of eliminating an NIF) The last bug fix in b64url near as I can tell was [this commit](https://github.com/apache/couchdb-b64url/commit/7c6324232c4728c7290ae6ec73bab67ff56912ef) from almost exactly twelve years ago. Which means that at least in terms of bugs per LoC, b64url has been safer than the Erlang VM itself for more than a decade. This PR comment is brought to you by @nickva making a joke and me feeling a bit cheeky. I haven’t spent much (any) time thinking about this PR in terms of actual performance, so I’ll leave that to y’all. I’ll even +1 the b64url removal if that’s the decision! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
