Benjamin-Philip commented on issue #5801: URL: https://github.com/apache/couchdb/issues/5801#issuecomment-3604870969
> I patched the built-in script like this: I left the regex implementation for completeness, but since we don't need to bench the old version, replacing it with the url-safe version works too. > Pretty sure there is a way to check if we're running a jitted emulator build too I'm not too familiar with how you package and distribute couchdb. I believe that the JIT is included in the default build, so it shouldn't be a problem in most deployments. > Maybe we could do a length limit, if it's < 100 bytes we use the built-ins, otherwise use the nif? Are you getting different results in this range? Typically how large are the bytes you encode? > With the built-in script I still see that the nif is faster even with the jit. Could you share the parameters you benchmarked with so that I can investigate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
