jiahuili430 commented on code in PR #5881:
URL: https://github.com/apache/couchdb/pull/5881#discussion_r2789082188
##########
src/couch_replicator/src/couch_replicator_scheduler_job.erl:
##########
@@ -685,7 +685,12 @@ init_state(Rep) ->
Stats = couch_replicator_stats:max_stats(ArgStats1, HistoryStats),
StartSeq1 = get_value(since_seq, Options, StartSeq0),
- StartSeq = {0, StartSeq1},
+ StartSeq2 =
Review Comment:
If both checkpoint and `since_seq` exist, may I compare their prefixes and
then decide which one to use? Like in the test case of
`t_replicate_with_checkpoint_and_since_seq()`.
```erl
compare_rep_seq(Seq1, Seq2) ->
[Prefix1 | _] = binary:split(Seq1, <<"-">>),
[Prefix2 | _] = binary:split(Seq2, <<"-">>),
binary_to_integer(Prefix1) > binary_to_integer(Prefix2).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
