nickva commented on code in PR #5881:
URL: https://github.com/apache/couchdb/pull/5881#discussion_r2789600059
##########
src/couch_replicator/src/couch_replicator_scheduler_job.erl:
##########
@@ -685,7 +685,12 @@ init_state(Rep) ->
Stats = couch_replicator_stats:max_stats(ArgStats1, HistoryStats),
StartSeq1 = get_value(since_seq, Options, StartSeq0),
- StartSeq = {0, StartSeq1},
+ StartSeq2 =
Review Comment:
Unfortunately we can't compare sequences reliably that way. If we were to
compare, we could get the number of pending changes with both sequences with
two separate extra requests but even that is not as reliable. Instead, I think
the best bet is to go with what we discussed in #5867 - mix the since_seq into
the replication ID generation hash and not use a since_seq if we find a
checkpoint (we can always compare with a 0 I think).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
